card-vibes icon indicating copy to clipboard operation
card-vibes copied to clipboard

Published 20 hours ago • verified publisher icon siddharthkp

Dependency React missing.

Open supra28 opened this issue 6 years ago • 4 comments

React is missing in package.json is that intentional? Would it cause any problem for someone contributing?

supra28 avatar May 31 '18 04:05 supra28

I guess it should be in peer dependencies

Well, right now there isn't a playground to even test it out, so idk how easy is it to contribute

siddharthkp avatar May 31 '18 07:05 siddharthkp

There is another problem I guess, the event listeners are not getting detached as there's no call to destroy() . I think it should be added to componentWillUnmount ? In both the repositories, here and react-vanilla-tilt.

supra28 avatar Jun 06 '18 04:06 supra28

Yeah, if there are a lot of cards, you might end up with a memory leak

Profiling http://awesometalks.party might be a good place to start

@SaraVieira heads up!

Feel free to create a pull request if there's a problem 😄

siddharthkp avatar Jun 06 '18 05:06 siddharthkp

The version used in http://awesometalks.party doesn't have the updated build after querySelectorAll was replaced by refs (Because the the project wasn't built again after the update). I've sent a pull request for that in this repository,

supra28 avatar Jun 06 '18 05:06 supra28