bundlesize icon indicating copy to clipboard operation
bundlesize copied to clipboard

update brotli-size to 4.0.0 and get rid of iltorb

Open gugadev opened this issue 3 years ago • 7 comments

Description

Update brotli-size to 4.0.0 and get rid of iltorb 2.4.5 (getting 404 errors because some releases are removed from repo).

Types of changes

  • New feature: update brotli-size dependency

gugadev avatar Mar 30 '21 21:03 gugadev

Hi maintainers! Is there any blockers to merge this PR?

romain-guillot-symphony avatar Apr 14 '21 08:04 romain-guillot-symphony

Hi!

Checkout https://github.com/siddharthkp/bundlesize/pull/320#issuecomment-810383358

siddharthkp avatar Apr 14 '21 10:04 siddharthkp

Hi,

I can't believe I have the same problem (about iltorb hard installation) and that you have an open PR on that !! But I can't use the bundlesize2 as I try to install antd package https://github.com/ant-design/ant-design/blob/master/package.json#L186 so I can only wait for your PR

So I'm asking the same : Is there any blockers to merge this PR? Do you have any schedule for it ? I'm only waiting for it 😄

Thanks !

BobForCat avatar Apr 21 '21 08:04 BobForCat

I also have issues with iltorb. @siddharthkp would it be possible to merge this and get rid of the dependency?

gracjan-sl avatar Sep 08 '21 08:09 gracjan-sl

Hi @gracjan-sl!

You might want to start using bundlesize2 that solves this issue: https://github.com/siddharthkp/bundlesize2#migration-from-bundlesize0180

siddharthkp avatar Sep 08 '21 09:09 siddharthkp

Is there any blockers for this PR to be merged?

I saw a sentence on bundlesize2's GitHub page

Note: When this package is feature complete, it will be merged back into the original project as [email protected]

Does that mean until bundlesize2 is merged back to this repo, the existing code will not be updated?

kebugcheckex avatar Feb 13 '22 07:02 kebugcheckex

Does that mean until bundlesize2 is merged back to this repo, the existing code will not be updated?

Pretty much, I'd recommend using bundlesize2, it solves for most of the use cases right now (not all).

I understand it's not good open source behavior but it's the best I've got right now 😅

siddharthkp avatar Feb 14 '22 11:02 siddharthkp