bundlesize icon indicating copy to clipboard operation
bundlesize copied to clipboard

Published 20 hours ago • verified publisher icon siddharthkp

fix firebase get method not returning its promise

Open mohsinulhaq opened this issue 4 years ago • 3 comments

Fixes: https://github.com/siddharthkp/bundlesize/issues/308, https://github.com/siddharthkp/bundlesize/issues/224

Description

  1. Currently, the /values endpoint throws 500 error while fetching master stats. Apparently, this commit https://github.com/siddharthkp/bundlesize/commit/9e4880be3acaa11fd88ef8f219252a3836f18460#diff-3f22b50a5bc8fc66727cf2798b216054L34 broke the functionality long time ago.

  2. After fixing 1, I found that the global message was still not reflecting the changes in bundle sizes, showing -null. I found that in https://github.com/siddharthkp/bundlesize/blob/master/src/reporter.js#L77, we access the file directly, which fails when the user provides a glob file in case they have a hash appended to their chunks.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

mohsinulhaq avatar Oct 06 '19 20:10 mohsinulhaq

@siddharthkp can we merge this?

mohsinulhaq avatar Oct 12 '19 13:10 mohsinulhaq

Ping @siddharthkp, can we get this in?

raunofreiberg avatar Feb 19 '20 12:02 raunofreiberg

Any news on this?

michalkvasnicak avatar Mar 17 '20 21:03 michalkvasnicak