bundlesize icon indicating copy to clipboard operation
bundlesize copied to clipboard

Exit script with error even if token is provided

Open weynsee opened this issue 5 years ago • 2 comments

Description

When bundlesize fails a check, exit with status code of 1.

Motivation and Context

In certain CIs, the exit status is used to indicate whether the build succeeded or failed. Currently, if a CI token is provided, the build exits with 0 status code always (even if the check failed) hence some CIs will always mark bundlesize builds as successful.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change) Previously passing builds in CIs will now fail if bundlesize check fails.

Checklist:

  • My code follows the code style of this project. ✅
  • If my change requires a change to the documentation I have updated the documentation accordingly. ✅
  • I have read the CONTRIBUTING document. ✅
  • I created an issue for the Pull Request ✅

weynsee avatar Jul 12 '18 03:07 weynsee

@siddharthkp Have you considered this PR?

oliverviljamaa avatar Nov 21 '18 14:11 oliverviljamaa

Some news on this PR ? bundlesize cannot be used on CI process without this feature 😕

kefranabg avatar Jun 06 '19 09:06 kefranabg