siddharthkp
Gitlab CI support
Description
For now added a check for gitlab so that the message which shows up for github doesn't show up in gitlab CI. Please see screenshots attached for the difference.
I wanted to make few other changes also so that few code paths which are still getting executed, shouldn't but that requires quite a bit of refactoring.
Gitlab has its own CI so we don't need to set the build status explicitly as it's done for other cases.
Motivation and Context
This PR along with https://github.com/siddharthkp/ci-env/pull/10 tries to address #19.
Screenshots (if appropriate):
Given below is sample project which was used to just run gitlab CI and use bundlesize. Repo: https://gitlab.com/swapnilmishra/test-ci
Failed CI
Passing CI
Message which is shown for github in above screenshots will not be shown for gitlab after the PR.
Types of changes
- Bug fix (non-breaking change which fixes an issue)
Checklist:
- My code follows the code style of this project.
- If my change requires a change to the documentation I have updated the documentation accordingly.
- I have read the CONTRIBUTING document.
- I created an issue for the Pull Request
@siddharthkp Have a problem with adding this ? I think this a great fix for now
Let me know the comments @siddharthkp. Would be happy to make them quickly.
@siddharthkp @SaraVieira I am done with my changes here and in ci-env PR.
@siddharthkp merge?*😊
On Sun, 5 Nov 2017, 13:03 Swapnil Mishra, [email protected] wrote:
@siddharthkp https://github.com/siddharthkp @SaraVieira https://github.com/saravieira I am done with my changes here and in ci-env PR.
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/siddharthkp/bundlesize/pull/180#issuecomment-341971635, or mute the thread https://github.com/notifications/unsubscribe-auth/ABALddH9L6QtlSEzMFze4IOttz2aUly1ks5szbI6gaJpZM4QR2v- .
--
Thank you Sara Vieira
@siddharthkp This looks ready to be merged. Are we waiting on any changes?
