bundlesize icon indicating copy to clipboard operation
bundlesize copied to clipboard

Disable WARN github token not found in output

Open itsuryev opened this issue 8 years ago • 3 comments

Do you want to request a feature or report a bug? Bug I guess

What is the current behavior? Right now I get following output:

 WARN  github token not found

    You are missing out on some cool features.
    Read more here: https://github.com/siddharthkp/bundlesize#2-build-status
   

 PASS  ../resources/dist/static/js/app.37cef5f1.js: 640.49KB < maxSize 670KB gzip 

If the current behavior is a bug, please provide the steps to reproduce. Do not set github token, run bundlesize on CI

What is the expected behavior? I use gitlab, so warning above simply adds noise to ouput. I would like to be able to suppress it somehow

If this is a feature request, what is motivation or use case for changing the behavior?

Please mention other relevant information.

  • node version
  • npm version
  • Operating system
  • bundlesize version
  • CI you are using

itsuryev avatar Oct 09 '17 14:10 itsuryev

Ah, good catch! I hadn't thought of that.

I wouldn't want to remove it completely because it is a pretty cool feature that I want people to use. But would definitely disable it for non-github folks.

I wonder if we can add another key in ci-env to pass the host/source and work with that.

Would you want to work on this?

siddharthkp avatar Oct 09 '17 14:10 siddharthkp

I also run into this and I'm using Github actions as a CI. I didn't need the status check on my PR as already have the one from my CI job.

I see in one of you PR that you disable it. Could we have a release of the library ? 😄

armandabric avatar Aug 13 '19 08:08 armandabric

@Spy-Seth Hey! I have removed this on the beta channel.

If you're not using comparison with master, you can start using that: https://github.com/siddharthkp/bundlesize/pull/324

siddharthkp avatar Aug 13 '19 11:08 siddharthkp