sbt-bom icon indicating copy to clipboard operation
sbt-bom copied to clipboard

use consistent line endings on all platforms

Open lhns opened this issue 11 months ago • 1 comments

Should we add a test for this? I have removed the "-w" option on diff but I think it would be better to leave that in because git crlf could be configured differently for different users making it harder for them to run the tests. Sadly the PrettyPrinter in CycloneDX is hardcoded and always uses the systems default line endings. Fixes #76

lhns avatar Jan 08 '25 16:01 lhns

Should we add a test for this? I have removed the "-w" option on diff but I think it would be better to leave that in because git crlf could be configured differently for different users making it harder for them to run the tests.

Good point. I agree making things easy across git crlf settings makes sense. Then we can have a dedicated test that checks for line endings (perhaps just searching for crlf strings in the output, ignoring the 'real' contents?)

Sadly the PrettyPrinter in CycloneDX is hardcoded and always uses the systems default line endings.

Maybe add an issue for this upstream?

raboof avatar Jan 08 '25 16:01 raboof