didcomm-python icon indicating copy to clipboard operation
didcomm-python copied to clipboard

Potential DIDComm did:peer:2 Spec Compliance Issue

Open TheTechmage opened this issue 1 year ago • 0 comments

I'm not too familiar with how the DIDPeer DIDs are supposed to work, but according to this comment, it appears that there may be some issues with Peer DID Numalgo 2 generation across libraries between https://github.com/sicpa-dlab/didcomm-rust/ and here. The output is different enough that it has caused a conversion layer to be built to convert the DID between libraries in order to maintain inter-operability. Daniel has submitted a PR to the Spec to make clarifications https://github.com/decentralized-identity/peer-did-method-spec/pull/62 but as of this moment it has not been merged.

Irregardless of the merge status, did:peer:2 DIDs generated by didcomm-rust and didcomm-python are incompatible with each-other when a service endpoint is defined. didcomm-python is expecting a flat servicesEndpoint structure, where-as didcomm-rust is expecting an object.

cc: @dbluhm

TheTechmage avatar Oct 11 '23 16:10 TheTechmage