vncdotool icon indicating copy to clipboard operation
vncdotool copied to clipboard

Switch from pycryptodomex to cryptography.io

Open geofft opened this issue 1 year ago • 4 comments
trafficstars

cryptography.io wraps an existing well-known cryptography library (OpenSSL) instead of implementing routines itself, and it's already a dependency of Twisted, so this reduces the overall number of cryptography libraries needed.

geofft avatar Jan 08 '24 20:01 geofft

I've done a little bit of unit testing by hand but let me try to make some real connections with this too, since I don't think there's much test coverage for this code. Also I'm open to feedback on whether this is a desirable thing at all.

geofft avatar Jan 08 '24 20:01 geofft

OK, I've confirmed that this works in both of the cases that are affected, i.e., password auth (with Xtightvnc) and Apple Remote Desktop (with macOS 13.6), so I think I got the code right :)

geofft avatar Jan 08 '24 23:01 geofft