redbeat
redbeat copied to clipboard
sibson
using uuid-$hostname-$pid replace default uuid as lock token.
We run multiple redbeat instances for high availability, and sometimes we find that the service is not behaving as expected, we want to know which server is running, but it's hard to know right now, so we want to use uuid-$hostname-$pid as a lock token to aid troubleshooting.
@sibson Do you have time to look at this pull request? We'd like to use this feature as soon as possible. Many thanks!
This seems like a good idea. If I'm understanding it correctly it means we're sticking machine identifying information into redis. I don't see any obvious problems with that but thought I'd mention in case someone sees an issue with doing so. It looks like there are some lint errors, if you clean those up and no one objects I'll merge.
Is there a specific waiting time? We would like to know approximately when we can merge and release a new version
Many Thanks!
A month has passed and it looks like no one has voiced any objections, can we merge now? @sibson
Many Thanks!