ngx-editor icon indicating copy to clipboard operation
ngx-editor copied to clipboard

Custom color picker for text/background color selecting popup

Open Mohammed-Rasik opened this issue 2 years ago • 1 comments

This PR contains:

  • [ ] bugfix
  • [x] feature
  • [ ] refactor
  • [ ] tests
  • [ ] documentation
  • [ ] others

Breaking Changes?

  • [ ] yes
  • [x] no

Checklist

  • [x] commit messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
    • A document related commit is prefixed "docs:"
  • [ ] docs have been added / updated (for bug fixes / features)

Describe Your Changes

HTML custom color picker is added in text/background color selecting popup. If want to choose different color from presets, user can use this color picker. User can choose color by picking/by typing hex code. Also recently picked colors from color picker, which is also different from presets, displayed in the same popup as 'Recent Colors'.

Does this PR affects any existing issues?

  • [ ] yes
  • [x] no

Mohammed-Rasik avatar Jun 26 '22 09:06 Mohammed-Rasik

Hi @Mohammed-Rasik Thanks for the PR. I forgot to get back on this.

Will look into this. Would have been better if a discussion/issue was created to discuss on this first. The reason the color picker is not added is that it looks/works different in different browsers.

And can you document the usage in the PR description too, api/options has to play along nicely with the current present.

sibiraj-s avatar Jul 21 '22 11:07 sibiraj-s

Closing as not planning to implement this. Thank you.

sibiraj-s avatar Dec 14 '22 18:12 sibiraj-s

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread.

github-actions[bot] avatar Jan 22 '23 01:01 github-actions[bot]