b2blaze icon indicating copy to clipboard operation
b2blaze copied to clipboard

Remove B2FileList's unused file cache

Open Katharine opened this issue 6 years ago • 1 comments

B2FileList maintains a cache of files in a bucket, and updates it on some (but not all) mutation operations. However, the cache is never read.

This PR removes the cache, primarily because it isn't used. As motivation, in its current implementation, maintaining the cache is extraordinarily expensive. In particular, every time a file is uploaded, the entire bucket is listed again. This is expensive in both requests and bandwidth, especially when uploading a batch of many files (when you will make O(n^2) requests to upload n files). Many (most?) B2 use cases don't need a complete bucket listing at all.

The behaviour of the cache could potentially be improved instead of removing it, but given it is entirely unused, doing so didn't seem worth the effort here.

Katharine avatar Jan 15 '19 07:01 Katharine

This solves #31

kaivi avatar Feb 15 '19 00:02 kaivi