b2blaze icon indicating copy to clipboard operation
b2blaze copied to clipboard

Use the provided mimetype in B2FileList.upload

Open Katharine opened this issue 6 years ago • 3 comments

The value passed for mime_content_type to B2FileList.upload was being discarded, leaving filename-based autodetection on in all cases.

Change upload to pass the mimetype through to the connector (which then handles it correctly).

Katharine avatar Jan 15 '19 05:01 Katharine

What happens if mime_content_type is None? Will it auto detect it?

sibblegp avatar Oct 10 '19 18:10 sibblegp

Yes — in that case the connector code defaults to b2/x-auto, which guesses from the file extension.

Katharine avatar Oct 10 '19 18:10 Katharine

Hi Katharine. I'm glad you contributed so much to the project. Is there a way we could talk privately about making you a direct contributor?

Sincerely, George P. Sibble

On Thu, Oct 10, 2019 at 11:27 AM, Katharine Berry < [email protected] > wrote:

Yes — in that case the connector code defaults to b2/x-auto ( https://github.com/sibblegp/b2blaze/blob/ac70185a1e16fb3bc7ce6c974b16fdbdbdb5234b/b2blaze/connector.py#L128 ) , which guesses from the file extension.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub ( https://github.com/sibblegp/b2blaze/pull/26?email_source=notifications&email_token=AAH2TKXYIPWX7L47YVWPGYTQN5XXTA5CNFSM4GQBC5PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA5KAPI#issuecomment-540713021 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAH2TKUZHPLUVG2VSIQ2U6LQN5XXTANCNFSM4GQBC5PA ).

sibblegp avatar Oct 10 '19 20:10 sibblegp