RePr icon indicating copy to clipboard operation
RePr copied to clipboard

Missing abs() when calculating the inter-filter orthogonality?

Open qinjian623 opened this issue 5 years ago • 12 comments

https://github.com/siahuat0727/RePr/blob/4fa1b8d30da1d9f88ccc29fe3ab1711811ef093d/main.py#L148

In paper it seems need an abs() op here.

qinjian623 avatar Apr 15 '19 06:04 qinjian623

Oh! You are right, I made a terrible mistake here! The result without abs() can't represent its orthogonality among others. I will fix it and re-run the experiments then. Thanks a lot!

siahuat0727 avatar Apr 16 '19 01:04 siahuat0727

Hi, I've ran the experiment with abs op. But found out the ranking prefer to prune the shallow layer of net. Maybe there are mistakes in my experiment settings.

After your rerun-experiment, would you mind to info me about your experiment result please?

Thanks.

qinjian623 avatar Apr 16 '19 02:04 qinjian623

Sorry for the late reply.

My results are the same as yours. Maybe there are more bugs in my implementation. I also hope you can let me know when you find other problems. Thanks.

siahuat0727 avatar Apr 18 '19 03:04 siahuat0727

Hi,

I have my own implementation. It also prefers shallow layer. Maybe we need contact the paper's author for more details.

Seems you speak Chinese. I think we can keep in touch with e-mail.

qinjian623 avatar Apr 18 '19 04:04 qinjian623

No problem. Keep in touch!

siahuat0727 avatar Apr 18 '19 14:04 siahuat0727

Have you re-run your experiments? @siahuat0727

BigFishMaster avatar Apr 25 '19 08:04 BigFishMaster

@qinjian623 I have contacted you at weibo, please keep on touching.

BigFishMaster avatar Apr 26 '19 06:04 BigFishMaster

@BigFishMaster Hi, I will re-run it this weekend and update the results on my blog.

siahuat0727 avatar Apr 26 '19 07:04 siahuat0727

@siahuat0727 This is the discussion on reddit. Somebodys doubt the result. https://www.reddit.com/r/MachineLearning/comments/ayh2hf/r_repr_improved_training_of_convolutional_filters/

BigFishMaster avatar Apr 26 '19 08:04 BigFishMaster

@siahuat0727 the result is too high in Fig.1 image

BigFishMaster avatar Apr 26 '19 08:04 BigFishMaster

@siahuat0727 orthogonal function in pytorch may help. https://pytorch.org/docs/stable/nn.html?highlight=orthogonal#torch.nn.init.orthogonal_

BigFishMaster avatar Apr 26 '19 10:04 BigFishMaster

@BigFishMaster Thanks! I've just updated my re-run results.

siahuat0727 avatar Apr 28 '19 07:04 siahuat0727