Dom Rodriguez
Dom Rodriguez
Agreed. I think it should only be used on `no_std` as well. I don't know how fully complete it is, but we can see from the docs... maybe?
Surely if we introduce the usage of `core2` in the main `structure` crate as an import, just like with `byteorder`, and use the same 'features' as we do before, that...
Sorry, I meant something like how `byteorder` is imported in the main structure crate. L137 to L138 on `src/lib.rs`. I was then thinking that if we're approaching this issue with...
I think I'd rather submit a PR that supports the `Error` type in one PR. What sort of errors are you thinking?
This is my initial work so far - https://gist.github.com/shymega/328dd231fcd96711361996b6a739025b It compiles but doesn't pass tests. I haven't committed yet as I'd like it to pass tests - hence the diff.
Not sure I fully understand. Been working on this some more. The main issue is the macro not importing the `core2` dependencies. I'm going to commit to a different branch...
For reference: https://github.com/liranringel/structure/commit/46f87c2403dd2ebe03639d59d98f3569f3cd2f6f
Sure, opening a PR now. I rebased the `birkenfeld` branch to merge my commits into one - that was necessary to tidy up the PR. So, as an FYI, this...
I made a mistake and opened the PR on the fork. I've since reopened this repo as of tonight. A bit stupid of me to not realise for this long!...
dupperinc [email protected] writes: > @shymega I am seeing the same error, were you able to figure out the cause? > > --- > > Reply to this email directly or...