Stanley Shyiko

Results 87 comments of Stanley Shyiko

Hi Elias. Interesting. I wasn't aware that is available through Homebrew :) From what I can tell https://github.com/Homebrew/homebrew-core/blob/master/Formula/jabba.rb is missing shell integration scripts (e.g. https://github.com/shyiko/jabba/blob/master/install.sh#L91). Without them none of the...

I'll update homebrew formula to include shell integration as soon as 1.0.0 is out (it's near completion).

@ketan thank you! This looks great. Any chance you would be willing to do something about Windows ([syscall.Exec returns EWINDOWS](https://github.com/golang/go/blob/master/src/syscall/exec_windows.go#L339))? Ideally, exec should work on all target OSs. A message...

@ketan I understand. I'm not asking to replace syscall.Exec. It should stay. All we need is runtime.GOOS == "windows" case :).

Up to you. I'm fine with either case.

Hi @ketan. Good idea. I can easily see how it can be useful for things like `jabba exec 1.10 jshell`, etc. PR is more than welcome.

Just so that it would be clear: I'm not ignoring this PR. I'll merge it in as soon as https://github.com/robbyrussell/oh-my-zsh/pull/6886 in closed.

Hi @allahbaksh. Can you please explain why `jabba link ...` and not `jabba install [email protected]`?

This would be awesome! We would need to put jabba.bat on the PATH somehow but other than that it looks like something worth doing. Any chance you would be interested...

https://github.com/shyiko/jabba/pull/86 merged in. I'll close this ticket as soon as changes are in master. @rubin55 Thanks again for the PR!