Scroll-to-Top button
Description
'added new component and folder PageUp that creates a button when clicked scrolls to top of page, placed over next page button. Also added profile
Related Issues
i used code sandbox, so the css elements did not load correctly in preview window for screenshots
Changes Proposed
Checklist
- [ Yes] I have read and followed the Contribution Guidelines.
- [ Yes] All new and existing tests passed.
- [ Yes] I have updated the documentation to reflect the changes I've made.
- [ Yes] My code follows the code style of this project.
- [ Yes] The title of my pull request is a short description of the requested changes.
Screenshots
Note to reviewers
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| dev-find | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 4, 2024 2:43am |
The button is not working.
You might need to use a ref and scroll to top like how its done in the app.js file
useEffect(() => {
profilesRef.current.scrollTo({
top: 0,
behavior: 'smooth',
});
}, [currentPage]);
seeing that its already in the same file, you could take profilesRef as a prop and write that method when your button is clicked(redundant code) or you could turn this into a function and then take that function as a prop and simply run that function when your button is clicked.
Also... please make an issue first before making your PR, we could have had a discussion and whether this was needed and the best location for it to be placed.
P.S. not too sure about the design, looks plain and we already have 2 buttons there. Also the button text is kinda vague.