shuttle icon indicating copy to clipboard operation
shuttle copied to clipboard

[Improvement]: bump sqlx to 0.8.1

Open nicolasauler opened this issue 1 year ago • 3 comments

Describe the improvement

This will allow consumers of the crate to update to the latest sqlx. Also, sqlx <= 0.8.0 has a reported security vulnerability, and the fix is in the works at 0.8.1, so maybe starting the upgrade to this new major release is already a good step in making sure consumers of the crate can upgrade as fast as possible to the non-vulnerable version.

Duplicate declaration

  • [X] I have searched the issues and this improvement has not been requested before.

nicolasauler avatar Aug 23 '24 21:08 nicolasauler

I'm also onboard for helping solve this issue, as I'm an interested party. I just never opened a PR on this repo and maybe could use some guidance, although from what I've seen the Contribution and Developing guides are quite thorough.

nicolasauler avatar Aug 23 '24 21:08 nicolasauler

Thanks for giving attention to this. It's an easy change to make: Bump the version in the shared db and AWS RDS crates, and make sure they compile. After that works, all examples using it can be updated.

jonaro00 avatar Aug 24 '24 21:08 jonaro00

I forgot that we already did this in https://github.com/shuttle-hq/shuttle/pull/1847. What we can do now that 0.8.1 is released is to bump it again. There is a bug in 0.8.1 that will make it not compile on Rust < 1.80 which our CI uses, but we can ignore that (just run the CI command locally with 1.80).

jonaro00 avatar Aug 26 '24 11:08 jonaro00

Seems like sqlx dep has already been bumped, and all that is needed is a new breaking release of shuttle-shared-db.

GnomedDev avatar Sep 06 '24 23:09 GnomedDev

Yep, solved in #1867. Awaiting release.

jonaro00 avatar Sep 07 '24 00:09 jonaro00

SQLx has been bumped to 0.8.2 on shuttle-shared-db 0.48.0! You should now be unblocked from this.

joshua-mo-143 avatar Oct 15 '24 22:10 joshua-mo-143

Thanks a lot, my friends! Closing issue as resolved.

nicolasauler avatar Oct 16 '24 00:10 nicolasauler