deploy-action icon indicating copy to clipboard operation
deploy-action copied to clipboard

Allow project restart

Open lasantosr opened this issue 1 year ago • 2 comments

When upgrading shuttle version, a restart is required according to the docs: https://docs.shuttle.rs/configuration/shuttle-versions#upgrading-shuttle-version

This PR allows the action to restart the project before the deployment

lasantosr avatar Jan 30 '24 17:01 lasantosr

Thanks for the suggestion!

I think this is a good enough solution for those that want it, but restarting the project at each deployment can become very chaotic (especially if pushing commits rapidly), which is why we still recommend a manual restart when you want to upgrade the shuttle version. I don't think having this as an official option is suitable, since we are planning to remove the need of restarting the project altogether (and each deployment gets its own up to date container). So, I think we can leave this open for visibility, and let anyone who wants to use it do so.

P.S. You could also consider supporting the idle minutes flag.

jonaro00 avatar Feb 02 '24 11:02 jonaro00

I think this is a good enough solution for those that want it, but restarting the project at each deployment can become very chaotic (especially if pushing commits rapidly), which is why we still recommend a manual restart when you want to upgrade the shuttle version.

Having it as a variable allows the job to enable or disable it based on user input or other conditions.

If you're planning to remove the need of restarting the project, then I can understand why it's not being merged, thanks for the explanation!

lasantosr avatar Feb 02 '24 11:02 lasantosr

Project restarts are no longer a thing on shuttle.dev

jonaro00 avatar Jan 23 '25 11:01 jonaro00