rickshaw Guard against d3 'length' undefined error

Guard against d3 'length' undefined error

Open abirmingham opened this issue 10 years ago • 3 comments

Occurs when Rickshaw.Graph.render() is called with no data. Here we simply check that scenario before calling d3. See issue #438.

This is my naive solution to the issue, however it does fix the issue in my application.

Jun 12 '14 18:06 abirmingham

Any chance this pull request will be accepted?

Jul 30 '14 22:07 djensen47

Any chance this pull request will be accepted?

@djensen47 Yes; however, it would be more likely to be accepted with tests.

Mar 25 '16 22:03 wilmoore

Hi @abirmingham,

Would you be interested in adding tests so we can get this merged?

Mar 25 '16 22:03 wilmoore