rickshaw icon indicating copy to clipboard operation
rickshaw copied to clipboard
verified publisher icon shutterstock

Dynamic Legend: Fix for Rickshaw GitHub Issue #89

Open mpderbec opened this issue 12 years ago • 4 comments

This pull request fixes up the Legend class so that it can properly respond to series that are being dynamically added/removed. I modified the extensions.html example so that it (quickly) adds the series one at a time to the graph. This will hopefully expose any non-dynamic problems in the future.

Tests conducted:

  • Extensions.html thoroughly tested by manual operation.
  • Exercised Highlight, Toggle and Order behaviors.
  • Executed nodeunit tests.

mpderbec avatar Jun 20 '13 19:06 mpderbec

I will mention that I attempted to use pull request #201 prior to embarking on this set of changes… Unfortunately it did not fix the issue for all edge cases and all of the current extensions.

mpderbec avatar Jun 28 '13 21:06 mpderbec

Thanks -- this is a good problem to solve. We have a branch around that aims to address some of these same issues. I'll take a pass through each and pull this together.

dchester avatar Aug 06 '13 21:08 dchester

How is the dynamic series branch doing, btw? It probably needs some work being rebased to current master, is that worth a shot? @dchester, do you remember what issues you had with the work so far and what needs to be done to get that branch and/or this PR merged?

rbu avatar Apr 12 '14 15:04 rbu

Probably should have that discussion on #341....

rbu avatar Apr 12 '14 15:04 rbu