changeDPI
changeDPI copied to clipboard
Add changeDpiBuffer method
This adds support for using buffers directly instead of FileReader/Blobs.
Hi @bmathews, i have a couple of questions i left in the PR code comments
please let the dist/index.js out of the changes, i ll build it as soon as i bump up the version number. Thanks for the contribution so far
Removed dist/index.js.
Thanks!
Hi @bmathews let the dist unbuilt. i will go up with the version bump.
We have still that Buffer question to solve. Monday i ll consult with someone since i do not run this library alone.
Did you get some idea meantime?
I was chatting about this a bit. Supporting Buffer properly outside node would mean add a dependency for the Buffer module. I thin the best part would be just convert the buffer to array and pretend this new method works on array. Leaving the conversion from and to Buffer outside the lib.
What do you think?
+1
i guess we can do something for this
Is this PR going to be merged?
hi @nateisleychamp i have to admit i forgot about it. I'll do my best to have a native node buffer method asap.
Would appreciate this too, to avoid converting ArrayBuffer --> Blob --> ArrayBuffer in Node.
(Edit: I ended up using bmathews's version directly as I couldn't get Blob polyfill to work. Works like a charm. 👍)
Which pull request will now be merged? @bmathews ? And where is the readDPI method? 😉
Hello i lost access to this repo for a while, but i should be able to fix things now.