changeDPI icon indicating copy to clipboard operation
changeDPI copied to clipboard

Add changeDpiBuffer method

Open bmathews opened this issue 6 years ago • 12 comments

This adds support for using buffers directly instead of FileReader/Blobs.

bmathews avatar Oct 26 '18 17:10 bmathews

Hi @bmathews, i have a couple of questions i left in the PR code comments

asturur avatar Oct 26 '18 22:10 asturur

please let the dist/index.js out of the changes, i ll build it as soon as i bump up the version number. Thanks for the contribution so far

asturur avatar Oct 26 '18 23:10 asturur

Removed dist/index.js.

Thanks!

bmathews avatar Oct 26 '18 23:10 bmathews

Hi @bmathews let the dist unbuilt. i will go up with the version bump.

We have still that Buffer question to solve. Monday i ll consult with someone since i do not run this library alone.

Did you get some idea meantime?

asturur avatar Nov 16 '18 22:11 asturur

I was chatting about this a bit. Supporting Buffer properly outside node would mean add a dependency for the Buffer module. I thin the best part would be just convert the buffer to array and pretend this new method works on array. Leaving the conversion from and to Buffer outside the lib.

What do you think?

asturur avatar Nov 20 '18 21:11 asturur

+1

onoranzefunebricloud avatar Jun 12 '19 20:06 onoranzefunebricloud

i guess we can do something for this

asturur avatar Jun 12 '19 22:06 asturur

Is this PR going to be merged?

nateisleychamp avatar Jan 28 '21 22:01 nateisleychamp

hi @nateisleychamp i have to admit i forgot about it. I'll do my best to have a native node buffer method asap.

asturur avatar Jan 29 '21 19:01 asturur

Would appreciate this too, to avoid converting ArrayBuffer --> Blob --> ArrayBuffer in Node.

(Edit: I ended up using bmathews's version directly as I couldn't get Blob polyfill to work. Works like a charm. 👍)

plaa avatar Oct 20 '21 10:10 plaa

Which pull request will now be merged? @bmathews ? And where is the readDPI method? 😉

stephan-fischer avatar Feb 26 '22 18:02 stephan-fischer

Hello i lost access to this repo for a while, but i should be able to fix things now.

asturur avatar Feb 26 '22 22:02 asturur