changeDPI icon indicating copy to clipboard operation
changeDPI copied to clipboard

change dpi buffer

Open dungmv opened this issue 5 years ago • 5 comments

change dpi from a buffer source

dungmv avatar Apr 27 '20 08:04 dungmv

Do not forget to also add a test please.

asturur avatar Apr 27 '20 08:04 asturur

Ok sorry, my bad, we have already a PR doing this: https://github.com/shutterstock/changeDPI/pull/8 that includes types detection and test. Did you try that code? any reason why you feel like this version is better?

asturur avatar Apr 27 '20 08:04 asturur

Ok sorry, my bad, we have already a PR doing this: #8 that includes types detection and test. Did you try that code? any reason why you feel like this version is better?

Sorry, I don't see it. So you can reject this pr

dungmv avatar Apr 27 '20 09:04 dungmv

I do not need to reject it, i wonder if you tried it and if it fits your need. If it does, i could merge that and we could try to polish what is missing if you want to help anyway with a contribution.

asturur avatar Apr 27 '20 09:04 asturur

I do not need to reject it, i wonder if you tried it and if it fits your need. If it does, i could merge that and we could try to polish what is missing if you want to help anyway with a contribution.

My project needs to save an image with 300 dpi from nodejs with Jipm. Jimp can get buffer and save to file, but it can't set dpi. so I need this feature for my project. btw, Jimp already defined image type, therefore, I don't need auto-detect format of the image

dungmv avatar Apr 27 '20 09:04 dungmv