react-folder-tree icon indicating copy to clipboard operation
react-folder-tree copied to clipboard

Published 20 hours ago • verified publisher icon shunjizhan

Add Typescript support with .d.ts file

Open NicolaLovo opened this issue 2 years ago • 2 comments

It would be great to have typescript support for typescript programmers, so they don't have to declare their own .d.ts file for this awsome module.

NicolaLovo avatar Jun 18 '22 10:06 NicolaLovo

Hey, thanks for the suggestion, I am indeed planning to rewrite the whole lib to TS, just has been too busy to do it. Will let you know once it's done 😃

shunjizhan avatar Jun 19 '22 06:06 shunjizhan

Thank you! I really appreciate your component, it saved me a lot of work.

NicolaLovo avatar Jun 19 '22 09:06 NicolaLovo

Love this component. And typescript would make it perfect

mard0n avatar Oct 25 '22 15:10 mard0n

Me three please haha

skillseeker-io avatar Oct 27 '22 07:10 skillseeker-io

Hey @shunjizhan, I was thinking about providing a Pull Request including TypeScript typings, i.e. a .d.ts file. These might not be 100% accurate, but it could help people now, while they are waiting for your TS rewrite of the lib. Is a PR welcome? Would you have time to review it?

IanStorm avatar Nov 30 '22 09:11 IanStorm

sure! welcome to provide a PR, I can review it

shunjizhan avatar Nov 30 '22 13:11 shunjizhan

just published a new version with types support, thanks to @IanStorm 's contribution! Feel free to try out the latest version and let me know if there is any issue

shunjizhan avatar Dec 03 '22 12:12 shunjizhan