rediska icon indicating copy to clipboard operation
rediska copied to clipboard

Issue #74: unsubscribe error fix

Open dimafern opened this issue 13 years ago • 4 comments

Issue #74: unsubscribe error fix

dimafern avatar Oct 10 '12 13:10 dimafern

We already discuss this:

ME: Connection from prev foreach may be wrong, if channels from different connections YOU:OK, but the problem is when you unsubscribe the connection is removed from connections list and you can't find it with getConnectionByAlias later. ME: Than move $this->_connections->removeChannel($channel) after the getting responses.

shumkov avatar Aug 07 '13 12:08 shumkov

$channel = $this->rediska->subscribe('bets', 60); $channel->unsubscribe(); Just subscribe and then unsubscribe

More detailed description is here https://github.com/Shumkov/Rediska/issues/74

On Aug 7, 2013, at 15:52 , Ivan Shumkov [email protected] wrote:

How can i reproduce this bug?

— Reply to this email directly or view it on GitHub.

dimafern avatar Aug 07 '13 15:08 dimafern

Ok thanks, but your solution is wrong if we have a channels with different connections

shumkov avatar Aug 07 '13 16:08 shumkov

Probably yes, it's wrong. It works for me with one connection. I didn;t fix it for multiple connections.

On Aug 7, 2013, at 19:09 , Ivan Shumkov [email protected] wrote:

Ok, but your solution is wrong if we have a channels with different connections

— Reply to this email directly or view it on GitHub.

dimafern avatar Aug 08 '13 08:08 dimafern