gnome-email-notifications icon indicating copy to clipboard operation
gnome-email-notifications copied to clipboard

Extended Extension - Now supports Notification Sound

Open ChitturiSaiSuman opened this issue 2 years ago • 1 comments

This Extension now supports Notification Sound

Note: Beware of Initial Setup. Multiple unread mails can cause the extension to play the Notification sound multiple times in a row.

ChitturiSaiSuman avatar Oct 04 '21 14:10 ChitturiSaiSuman

Hi. Thanks for the PR. Please make the following changes:

  • Remove the python file. I only want JavaScript in this project.
  • Remove the sound file. I don't like it and the user should be able to input their own sound file. Maybe you could find a way to play gnome default sounds.
  • Add a setting to enable sounds and make the default to false. Most users of this extension probably don't want to suddenly hear a bunch of sounds.

I found a similar extension that plays a beep sound on a timer with a setting for alternate commands, maybe you could draw inspiration from that: https://github.com/rusins/beep-timer

shumingch avatar Oct 10 '21 04:10 shumingch