react-geocode icon indicating copy to clipboard operation
react-geocode copied to clipboard

Published 20 hours ago • verified publisher icon shukerullah

Type definition files

Open kaityhallman opened this issue 5 years ago • 5 comments

My team is using Typescript with this package. Can we have a type definition file?

kaityhallman avatar Jun 17 '19 20:06 kaityhallman

Hi, can anyone from your team submit PR? It will be helpful.

shukerullah avatar Sep 22 '19 10:09 shukerullah

@pouncyisdead would you like to submit PR?

ziyaddin avatar May 07 '20 16:05 ziyaddin

I'm still trying to get the type bindings right on this. Sorry for the delay.

On Thu, May 7, 2020 at 9:17 AM Ziyaddin Sadigov [email protected] wrote:

@pouncyisdead https://github.com/pouncyisdead would you like to submit PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/shukerullah/react-geocode/issues/24#issuecomment-625354319, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXVDWOIWYXSAWQBEV522UTRQLNJPANCNFSM4HYZ6N5A .

pouncyisdead avatar May 07 '20 23:05 pouncyisdead

It's okay. I think the current state of the type bindings is good enough.

ziyaddin avatar May 09 '20 12:05 ziyaddin

Hello @kaityhallman and @pouncyisdead,

We've added TypeScript type definitions to the latest version. Could you please test the package with your setup and let us know if everything works as expected? Your feedback is valuable!

shukerullah avatar Sep 19 '23 17:09 shukerullah