David Shiflet

Results 53 comments of David Shiflet

I think we should revise this plan a bit and move to "github.com/Azure/azure-sdk-for-go/sdk/azidentity" It provides a broad set of credential types with little extra code needed in the driver. Here's...

@kardianos is there any effort underway to add the message support to go-mssqldb? If not I can take a stab at it to support my own project, as I don't...

To summarize - I will try the model described in @kardianos 's earlier comment based on the `sqlexp` interfaces as a starter. Once that's shown to work I would look...

I'm looking to get the same messages for `envchange` (which may also come via the info/error channel) that sqlcmd shows: ``` 1> use tempdb 2> go Changed database context to...

I'm fairly sure the driver should return both result sets and the error in between. I'm trying to replicate `sqlcmd` behavior for the most part, and that's what we get....

I think your callback model looks reasonable. I think it's kinda clunky to have to put it on every command though, when it would be scoped per connection for most...

@kardianos do you expect these messages can be sent directly from `tokenProcessor` or will `tokenProcessor` just add more token types to the channel and then the callers of `nextToken` will...

Hmm I think `processQueryResponse` has to return right away and leave all the actual processing to `processSingleResponse` in order to make this work the way it's intended. Otherwise the caller...

Having spent a bit more time tinkering I think I need to pass the `ctx` to `processSingleResponse` and make it responsible for all the message posts. It will send MsgNextResultSet...

I think this code in sql.go is going to be problematic: https://github.com/golang/go/blob/6e738868a7a943d7d4fd6bb1963e7f6d78111726/src/database/sql/sql.go#L2978 It closes the `Rows` object if `HasNextResultSet` returns false. With the message queue model, we don't want the...