nextra icon indicating copy to clipboard operation
nextra copied to clipboard

feat: add more social icon

Open ikhsangama opened this issue 1 year ago • 12 comments

add more some common social media icon

ikhsangama avatar Apr 27 '24 16:04 ikhsangama

⚠️ No Changeset found

Latest commit: d67bd9407ab508e3a9af780b5f7b759c91c0d4a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 27 '24 16:04 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 5:29pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 5:29pm

vercel[bot] avatar Apr 27 '24 16:04 vercel[bot]

@ikhsangama is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 27 '24 16:04 vercel[bot]

Facebook, Twitter, Whatsapp, Threads in that case maybe too?

Netail avatar May 07 '24 09:05 Netail

Telegram 🙏

glmn avatar May 13 '24 10:05 glmn

Facebook, Twitter, Whatsapp, Threads in that case maybe too?

@Netail isn't Twitter icon already reserved here as 'X'? Do we need legacy logo?

ikhsangama avatar May 15 '24 12:05 ikhsangama

Facebook, Twitter, Whatsapp, Threads in that case maybe too?

@Netail isn't Twitter icon already reserved here as 'X'? Do we need legacy logo?

Woops, you're right hahaha. Still not used to it being called X now

Netail avatar May 15 '24 13:05 Netail

Terima kasih 🙏

Netail avatar May 15 '24 16:05 Netail

image

ikhsangama avatar May 15 '24 16:05 ikhsangama

image

Wait isn't that x just a close icon instead of the x (formally twitter) logo

Netail avatar May 15 '24 16:05 Netail

whoops hahaha just realize the logo is different, will revert and add new one with "XSocialIcon" or "XTwitterIcon" which naming is better? Open for better naming suggestion

ikhsangama avatar May 15 '24 16:05 ikhsangama

Updated! image

ikhsangama avatar May 15 '24 17:05 ikhsangama

thanks, but I don't think I would like to merge it, I would like to keep icons minimal and would suggest you to use icons library or copy-paste needed icons directly for your project

dimaMachina avatar Jun 08 '24 12:06 dimaMachina