Shu Ding comments

Results 403 comments of


                                            Shu Ding

Inserting a Final Payload onCompletion

You can do `stream.pipeThrough(transformStream)` where `transformStream` appends an extra chunk on flush: https://developer.mozilla.org/en-US/docs/Web/API/TransformStream/TransformStream

Announcing Vercel OG

Hey @nomercy360 could you reproduce it in the playground: https://og-playground.vercel.app? You can open an issue in https://github.com/vercel/satori and we will take a look!

fix: Mark text/x-component as compressible

Hi @dougwilson, I just updated the PR to follow the contributing guidelines with sources added.

Shared CSS is bundled multiple times with App Router in Next

Hey! This isn't specifically related to vanilla-extract, it's the current behavior if you use global CSS or CSS modules in `app/` as well. And we're thinking about improving it. The...

Shared CSS is bundled multiple times with App Router in Next

https://github.com/vercel/next.js/pull/50406 should fix this!

fix: incorrect data URL parsing

Thanks @kiwiyou! Could you please add a test case for it so it won't regress in the future?

Correctly position font baseline and line-height

Great work, thank you!

Type 'ArrayBuffer' is not assignable to type 'string'. when using local image.

Yeah this is unfortunately something Satori can't work around. If it provides a `.d.ts` to allow Buffer/ArrayBuffer values for img tag's `src` field, it will be a global TypeScript override...

refactor: replace opentype with harfbuzz

Super excited to see this proof of work, this will fix a lot of tricky issues in Satori! Thanks for the great work as always @LuciNyan! > Currently I am...

refactor: replace opentype with harfbuzz

> hahaha, harfbuzz is a big killer, which has more feature which harfbuzzjs does not support. As far as I know, harfbuzzjs only does basic work and does not support...