Shubham Shukla

Results 35 comments of Shubham Shukla

Same case with edit sub-command too.

I agree. Even though the software says it doesn't store the password, having to trust a unknown software(If they haven't seen the code), is a bad habit. As mentioned in...

Fixed conflicts from #292

Well I don't get to use pull request that often as I don't manage any big repo. I will see if I can test it this week.

Though the tests in #308 are not very exhaustive(We need more tests). But I tested by creating a branch off of this(#288) and then merging #308 into it. All test...

@davidCarlos thanks. You are right. I will reduce the no of commits. Right now I am working on improving local testing. Since the tester will use a fake github account...

One more thing I will fix is the indentation style. It doesn't match the rest of the project. I will fix it before squashing commits.

@davidCarlos can also evaluate whether the information in readme is enough to setup for local testing as well as setting up travis-ci for fork.

One problem is that the secure(We marked display these in build log to false) env varriables `GITHUB_USER` and `GITHUB_PASSWORD` are not provided by travis while building pull requests from fork....

One more thing that needs to be fixed is deleting the tokens once done with the tests(We can add a flag if the user don't want to delete it). Since...