Shubham Shukla
Shubham Shukla
@caifara You should create a separate issue for this. (As far as I can understand) #289 is about the problem where branch prefix was being used as milestone number and...
@drazisil I tested it when I created it, but I no longer use ghi (Havne't been active on github lately). So can't say whether its good now. I will create...
I started working on it few days back (https://github.com/shubhamshuklaer/ghi/tree/travis-ci), though I stopped for now. There are few problems.. 1. All the code needed to talk to ghithub, needs to be...
@AlexChesters No. I meant that if we have to test for eg. creating an issue, we will have to talk to github to test whether the issue was correctly created....
@davidCarlos Well I don't think that there will be any major difficulty. What I was trying to say that we have to make some decisions for how much code to...
I started working on this again. I will try to implement basic tests first.
@davidCarlos I found this library https://github.com/typhoeus/typhoeus and this has made life easier(Only had to write around 30 lines for talking to github). I have written test for token generation, opening...
@davidCarlos Though one more benefit of mocks will be that we can test fast. While developing we can just run a specific test(And run the talking to github part in...
Though default behavior of `ghi open` is opening issue, but default behavior of `ghi milestone` is list milestones, but still consistency is good.
~~I created another pull request as interface of edit also needs to be updated. So I am closing this.~~ Wrong comment