Shubham Bajpai

Results 9 comments of Shubham Bajpai

Addressed most of the review comments. Still trying to figure out how to manage errors properly, need some guidance on that. For the pool import part the current code can...

> Please do resolve the conversations that you've addressed as suggested by the reviewer in question. Done :+1: > We can try to help if we know what problems you're...

> @shubham14bajpai as the test run points out the format is wrong in some places. Did you run `cargo fmt` on it? I guess like me (and perhaps other?) you...

This might help us in defining the fields https://github.com/vmware-tanzu/cluster-api-provider-bringyourownhost/pull/501#issuecomment-1110310832

The cluster information already exists on the byohosts as a lable `cluster.x-k8s.io/cluster-name` and one can see that using below command. Adding it would be making the information repetitive. ```shell $...

Would the below two commands make it more informative to decide hosts to choose for provisioning. The standard command would give the os, arch, distribution for the hosts. ```shell $...

> Hey @shivi28, @Shubbhang351 was working on this for a hackathon, if he no longer has cycles to finish this I could take this up :slightly_smiling_face:

Hi @soumya-dash3, sure you can work on this.