shuangkun tian

Results 35 comments of shuangkun tian

I think this is reasonable. Can you add some tests, such as deploying a plugin under default, another plugin under controller, and checking the sidecar of the pod under default.

looks the same reason with https://github.com/argoproj/argo-workflows/issues/12895, and will be fixed by https://github.com/argoproj/argo-workflows/pull/12928

Thank you for your reply. I would like to confirm a question. Do you think it is reasonable to pass the retry parameter through the spec? This will increase the...

Hi @agilgur5 , can you give me your vote so that I can better solve these comments? Thanks.

@agilgur5 Thank you for your reply. I have modified a version. Can you help me take a look?

Maybe we can define a layer suspend mechanism (between workflow and steps) and estimate the total resources for next layer. When our quota is reserved, we will perform a one-layer...

The current design indeed ignores daemon failed. https://github.com/argoproj/argo-workflows/blob/934bf179a703a365a6a5eddfa6edb788492eac79/workflow/controller/operator.go#L1336