Madhur Shrimal

Results 40 comments of Madhur Shrimal

@ncitron so here's my first ever Rust PR. From what I understand this is what I got. Would love to get some feedback on general rust practices and of course...

> This is a good start. Structurally things look about right. > > One thing that I think got mixed up is that you are attempting to make a request...

> This is a good start. Structurally things look about right. > > One thing that I think got mixed up is that you are attempting to make a request...

Hey @ncitron , I got the rpc server working. Take a look. I tested it by running it locally. works as expected Now I am trying to construction the output...

> For fetching the `withdrawal_storage_root` value, we need to use getProof and provide `0xEF2ec5A5465f075E010BE70966a8667c94BCe15a` as the address for optimism Goerli (the message passer contract). We should add this to ChainConfig....

> For fetching the `withdrawal_storage_root` value, we need to use getProof and provide `0xEF2ec5A5465f075E010BE70966a8667c94BCe15a` as the address for optimism Goerli (the message passer contract). We should add this to ChainConfig....

@ncitron this is ready to review. You can see the request/response in the description. There are few more tasks (rpc port from config, some error handling etc) - I am...

> @ncitron this is ready to review. You can see the request/response in the description. There are few more tasks (rpc port from config, some error handling etc) - I...

> Looks like you have a formatting error. You can run `cargo fmt` on your code to resolve. whoops. Done. thanks!

> LGTM! > > Thanks for the contribution! This will allow us to interact with services such as [clabby/op-challenger](https://github.com/clabby/op-challenger) to automatically detect and challenge fraud which is a huge win...