Shrilakshmi Shastry

Results 43 comments of Shrilakshmi Shastry

> > https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog > > @shrilakshmishastry as per the docs, I think you can remove the `ESC` handling as it shouldn't be needed anymore and taken care of by the...

> ![image](https://private-user-images.githubusercontent.com/39559178/325786510-9b7e5ff9-663a-435c-b222-d34afc3273e9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQxODM3NzMsIm5iZiI6MTcxNDE4MzQ3MywicGF0aCI6Ii8zOTU1OTE3OC8zMjU3ODY1MTAtOWI3ZTVmZjktNjYzYS00MzVjLWIyMjItZDM0YWZjMzI3M2U5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MjclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDI3VDAyMDQzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkwNjc4MjE3MzFkNmIxNjYyYThmOTYwOGJmOGQ5YzI4MDEyMTYyZGRmNzI1NGFiNGE3YzYwMjhlMjNlMWUzMWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.28UBl2oo1eCDXRCy7x3FQyTYYrMYc7C72L8fZy8aT1M) > > I found that the "toasts" are now in the background, behind the dialog/backdrop instead of the foreground. This is probably due to how the `dialog` element...

> > ![image](https://private-user-images.githubusercontent.com/39559178/325786510-9b7e5ff9-663a-435c-b222-d34afc3273e9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQxODM3NzMsIm5iZiI6MTcxNDE4MzQ3MywicGF0aCI6Ii8zOTU1OTE3OC8zMjU3ODY1MTAtOWI3ZTVmZjktNjYzYS00MzVjLWIyMjItZDM0YWZjMzI3M2U5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MjclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDI3VDAyMDQzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkwNjc4MjE3MzFkNmIxNjYyYThmOTYwOGJmOGQ5YzI4MDEyMTYyZGRmNzI1NGFiNGE3YzYwMjhlMjNlMWUzMWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.28UBl2oo1eCDXRCy7x3FQyTYYrMYc7C72L8fZy8aT1M) > > I found that the "toasts" are now in the background, behind the dialog/backdrop instead of the foreground. This is probably due to how the `dialog`...

Hey @danilowoz 👋 Thanks for reviewing !! Did you get a chance to try it out ? I am not satisfied with how I handled the outline when the tab...

> I'm a bit hesitant about adding a ring focus over the code editor, giving the following reasons: > > * There is already a visual focus indication in the...

[feat: add unique id to each tab and tab panel for aria-* attributes](https://github.com/codesandbox/sandpack/pull/1184/commits/a127706ac21e44d8eadf032eb235f5e0b34d5410) 1. I used `useSandpackId()` in this commit to generate unique values for the ` aria-labelledby` and `aria-controls`...

In the [refactor: make activeFileUniqueId as optional paramater in FileTabs](https://github.com/codesandbox/sandpack/pull/1184/commits/b63d307ebf0d337b3a300cdd4e3ff87e0308488a) commit, 1. I have made ` activeFileUniqueId` as optional. So it doesn't break the existing consumption 2. fixed the ts...

Hey @ad1992 👋 I have a fix for this. I will fix it along with [this PR](https://github.com/react-tags/react-tags/pull/985). The issue is: Generally node_modules are precompiled to `common.js` (non-modular )versions of js...

this issue is similar to https://github.com/vuejs/vue/issues/10277