frappe_tinymce icon indicating copy to clipboard operation
frappe_tinymce copied to clipboard

fix: compatible with frappe dialog email when pre-fill content and get newest content.

Open anhlevfx opened this issue 2 years ago • 4 comments

When create a new email, frappe will popup a dialog, if we access form doctype in here will throw undefined exception. Check undefined is necessary. Beside, send email action will call function get_input_value, the result will always empty because it use the function in class ControlCode. So, the extend class must override it.

anhlevfx avatar Nov 24 '22 11:11 anhlevfx

can you add a GIF, this will help me understand the the fixes

shridarpatil avatar Nov 24 '22 13:11 shridarpatil

Sorry, recently I'm too busy for gif record. The fix I submitted for two issues:

  1. Can't open email popup like this Screenshot 2022-11-30 at 09 57 37
  2. Content email will empty. Screenshot 2022-11-30 at 10 01 07

anhlevfx avatar Nov 30 '22 03:11 anhlevfx

Email template not appear when select Email Template from Email PopUp

mohsinalimat avatar Mar 23 '23 11:03 mohsinalimat

https://github.com/shridarpatil/frappe_tinymce/issues/7

mohsinalimat avatar Mar 23 '23 11:03 mohsinalimat