frappe_tinymce icon indicating copy to clipboard operation
frappe_tinymce copied to clipboard

TinyMCE Breaks Frappe In-App Email Functionality

Open batonac opened this issue 2 years ago • 4 comments

Describe the bug This plugin is great, thanks so much for making it available! In my experience, it delivers on it's promise to load the TinyMCE editor instead of Quill in the standard text editor fields. Unfortunately, it simultaneously breaks the in-doc Email functionality in Frappe.

To Reproduce Steps to reproduce the behavior:

  1. Install frappe_tinymce
  2. Open any document.
  3. Scroll down to the bottom and select "New Email"
  4. See error in the browser console.

Expected behavior "New Email" should trigger a modal that allows the user to initiate a new email from the platform.

Actual behavior Nothing happens! The action just triggers an error in the console.

Additional context This was tested and triaged in both Firefox and Chrome browsers, on Frappe version 13 and 14 beta.

Here's the browser console error:

Uncaught TypeError: can't access property "open", o is undefined
tinymce.min.js:9:333666

And full browser console error log: erp.avu.nu-1648925803208.log

batonac avatar Apr 02 '22 18:04 batonac

Hey! I saw this issue listed on Bounty source. Is this still open to work upon?

pratik9315 avatar Jul 02 '22 13:07 pratik9315

Yes!

batonac avatar Jul 02 '22 13:07 batonac

Hey there. So the thing is, I currently do not possess a Linux system😅 I would've love to work on this but for now I would not be able to complete it. Thanks.

pratik9315 avatar Jul 02 '22 16:07 pratik9315

No need for a Linux system in the age of WSL. But if that's not a great option, I'd be glad to provide a vps instance for this if you have the skill set otherwise.

batonac avatar Jul 02 '22 17:07 batonac

It also breaks any Doctype which contains a text input in the quick create menu. For example, creating a new Issue doesn't work anymore as well.

I'm guessing tinyMCE basically doesn't load properly in any pop up. The built in email functionality is pretty useful for sending quotes, purchase orders and other routine documentation, and tinyMCE is great for writing long documents.

zuron7 avatar Dec 07 '22 10:12 zuron7