regex-for-regular-folk icon indicating copy to clipboard operation
regex-for-regular-folk copied to clipboard

Navigation

Open GaryPWhite opened this issue 2 years ago • 2 comments

Love your book!

I'm a keyboard person trying to navigate the non-single page, and noticed there wasn't an obvious cue or keyboard pattern to do so. Would you be opposed to me putting in a PR for arrow keys / AD to move been pages? I'm pretty familiar with gatsby and would be thrilled to contribute :)

GaryPWhite avatar Jan 21 '22 15:01 GaryPWhite

also.. might be a separate issue... but noticing that the pages actually reload between next/previous. I'm sure using a <Link> would have a little better performance, but there might be a reason you hadn't done that! Let me know, it should be trivial to put both of those in!

GaryPWhite avatar Jan 21 '22 15:01 GaryPWhite

Would you be opposed to me putting in a PR for arrow keys / AD to move been pages? I'm pretty familiar with gatsby and would be thrilled to contribute

That sounds like a good idea. The PR's welcome!

but noticing that the pages actually reload between next/previous. I'm sure using a would have a little better performance

True. That would be cool, but only if there's a way to have it degrade gracefully when javascript is disabled.

shreyasminocha avatar Jan 22 '22 08:01 shreyasminocha