learnp2p icon indicating copy to clipboard operation
learnp2p copied to clipboard
verified publisher icon shresthagrawal

Refactor all the code to latest version of js-libp2p

Open shresthagrawal opened this issue 5 years ago • 5 comments

shresthagrawal avatar Mar 24 '20 19:03 shresthagrawal

I have taken this up and refactoring the code using js-libp2p v0.27.4.

prateekreddy avatar Apr 14 '20 05:04 prateekreddy

@prateekreddy awesome! Looking forward for your PR!

shresthagrawal avatar Apr 14 '20 06:04 shresthagrawal

@shresthagrawal In chapter 6, currently start and stop events are being used to subscribe and unsubscribe from he pubsub. But in the latest version these events are not present anymore. I was wondering if you would want to structure it in a different way. I have upgraded the libp2p version for the first 5 chapters.

prateekreddy avatar Apr 21 '20 12:04 prateekreddy

@prateekreddy yaah sure go for it. I can see in your branch that you have structured it such that everything which was previously under start event callback is now under the below the await libp2p.start().

Kudos for you progress! Nice work Can you create a PR of the your work with WIP in description. It's easier to track progress if the issue for everyone who checks out the repo.

shresthagrawal avatar Apr 22 '20 06:04 shresthagrawal

Will be fixed by #11

acolytec3 avatar Aug 01 '20 01:08 acolytec3