web-components-todo icon indicating copy to clipboard operation
web-components-todo copied to clipboard

use rollup to bundle lit-element-2.1

Open aelbore opened this issue 7 years ago • 2 comments

  • use rollup to bundle
  • use inlineLitElement rollup plugin to import and inline css/scss

Bundle size alt text

aelbore avatar Apr 07 '19 03:04 aelbore

Is really the bundle change a key feature there?

Em dom, 7 de abr de 2019 00:59, Jay [email protected] escreveu:

  • use rollup to bundle
  • use inlineLitElement rollup plugin to import and inline css/scss

Bundle size [image: alt text] https://github.com/aelbore/inline-styles-lit-element/blob/todo-lit-element/bundle-size.png?raw=true

You can view, comment on, or merge this pull request online at:

https://github.com/shprink/web-components-todo/pull/30 Commit Summary

  • use rollup to bundle

File Changes

Patch Links:

  • https://github.com/shprink/web-components-todo/pull/30.patch
  • https://github.com/shprink/web-components-todo/pull/30.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/shprink/web-components-todo/pull/30, or mute the thread https://github.com/notifications/unsubscribe-auth/AAh-l6ktSJLOV8p2BBK0hdX1wulAG_Tuks5veW0wgaJpZM4cgjCi .

sombriks avatar Apr 07 '19 04:04 sombriks

@sombriks actually not really familiar with how webpack bundle it, and i notice that in https://wc-todo.firebaseapp.com page the lit-element-v2.1 has 8.4kb gzipped so when i try rollup it trim down almost 1KB size also i use rollup plugin to inline import css to make it clean.

aelbore avatar Apr 07 '19 04:04 aelbore