showdown
showdown copied to clipboard
showdownjs
fix(table): tables with a preceding footnote are now rendered correctly
Hey @shawnfunke - I am not a contributor of this project etc. But I would suggest providing some tests to ensure this provides the proper fix.
In the meantime hopefully @tivie or @SyntaxRules can look at merging this PR.
pinging them both in hope they see this.
Hi @MarketingPip,
The tests are located in test/functional/makehtml/cases/features/tables/..., the
provided Markdown file is rendered and compared with the corresponding HTML
file. I can't think of any specific cases that aren't already tested through other
existing tests definitions, but I'm open to suggestions.
@shawnfunke I will be honest I completely missed seeing your tests!
No :coffee: when looking earlier!
Hopefully the repo maintainers see this - as it seems it has been requested. Tho it looks like they need some more support to close some existing issues (as they are getting out of hand)
ps; I don't know if this is up your alley but being on the regex side of things, (assuming it use's a regex match) or last match of character. But maybe you want to add a fix for this into another PR if willing.
Issues with link format / regex · Issue #951 · showdownjs/showdown
@MarketingPip, if this pull request gets merged I don't mind looking into your issue further and proving a fix for it. But i'll wait for now since I don't want to put the work in, while not knowing if it actually will get merged.
@shawnfunke more than 100% understandable. Considering the maintainers have dismissed some previous pull requests for fixes that could have been applied previously. (and allowing someone else to end up re-writing those functions AGAIN) instead of applying a PR that could have already fixed it.
I don't want to spam the owners of this. But I tagged them in previous issues etc in hope it grabs some attention + possibly hopefully allow some other maintainers etc to close some previous issues & more etc. Before this project get's more cluttered than it already is!
Other than that, sorry to be a bothersome & jump in on your PR.
Tho I do hope this does help get a move on the maintainers for merging your PR. :+1:
@MarketingPip, don't worry you're good, I don't mind at all. It'd be great if third-party contributions would be accepted again.