short icon indicating copy to clipboard operation
short copied to clipboard
verified publisher icon short-d

[REFACTOR] [UI] $content-width SCSS variable not responsive to all screen sizes

Open Coteh opened this issue 5 years ago • 2 comments

What is frustrating you? The $content-width SCSS variable, found in frontend/src/component/styles/dimension.scss is set to 1200px currently, which works for desktop, but does not make sense for mobile. Components affected are: Header, Footer (but it looks fine since it's centered and just text), Section, and UserShortLinksSection.

Your solution Refactor so that the $content-width variable's value is calculated from the current screen width.

Screenshots iPhone X/XS screen dimensions for example: image

Coteh avatar Apr 29 '20 20:04 Coteh

You mean not responsive

magicoder10 avatar Apr 29 '20 21:04 magicoder10

Yes! Not responsive I mean. Thanks! 👍

On Apr 29, 2020, at 5:52 PM, Harry Liu <[email protected]mailto:[email protected]> wrote:

You mean not responsive

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/short-d/short/issues/722#issuecomment-621484464, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAY74PSS3CILXKUUYKVUKDTRPCOQTANCNFSM4MUB6IDQ.

Coteh avatar Apr 29 '20 22:04 Coteh