short icon indicating copy to clipboard operation
short copied to clipboard

Add story for Table component

Open Coteh opened this issue 4 years ago • 5 comments

Addresses the Table story in #954.

Leaving in Draft until these items are done:

  • [x] Complete knobs for columns widths and header font size
  • [x] Determine whether it's necessary to have knobs for align headers and align body columns
  • [ ] Decide whether to transition from knobs to Storybook Controls edit: will address in separate PR

This PR also adds Storybook Backgrounds, as I wanted to add the color #fafafa, which is being used underneath the Favourite short links table in the homepage, as a background colour for the canvas. This will make the Table component stand out better. I also set #fafafa as the default background colour for story canvases.

image

Coteh avatar Aug 22 '20 00:08 Coteh

Codecov Report

Merging #1001 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1001   +/-   ##
=======================================
  Coverage   52.58%   52.58%           
=======================================
  Files         142      142           
  Lines        3564     3564           
  Branches      168      168           
=======================================
  Hits         1874     1874           
  Misses       1623     1623           
  Partials       67       67           
Flag Coverage Δ
#golang 72.03% <ø> (ø)
#typescript 22.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
frontend/src/component/ui/Table.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ebc6a04...c243c26. Read the comment docs.

codecov[bot] avatar Aug 22 '20 00:08 codecov[bot]

Readied this PR for review, will convert it to Storybook Controls if we start using it.

Coteh avatar Aug 22 '20 20:08 Coteh

@Coteh Control seems good. Let's do it!

magicoder10 avatar Aug 28 '20 06:08 magicoder10

@byliuyang I think what I'll do is merge this in as-is, then make a separate PR for Controls and convert all existing stories to use Controls in that PR. What do you think?

Coteh avatar Aug 28 '20 16:08 Coteh

@byliuyang Screenshot added

Coteh avatar Sep 02 '20 01:09 Coteh