shorebird icon indicating copy to clipboard operation
shorebird copied to clipboard

feat: Add support for signing macOS PKG installers and implement productbuild functionality

Open ahmtydn opened this issue 5 months ago โ€ข 1 comments

PR: Add support for signing macOS PKG installers and implement productbuild functionality

Description

This PR introduces support for signing macOS PKG installers and implements the necessary productbuild functionality. The changes include:

  • Added a wrapper for the productbuild command to create signed PKG installers.
  • Updated the macOS release flow to optionally generate a signed PKG installer if a signing identity is provided.
  • Extended CLI options to allow specifying a Developer ID Installer identity for PKG signing.
  • Added tests for the new productbuild functionality.

Type of Change

  • [ ] โœจ New feature (non-breaking change which adds functionality)
  • [ ] ๐Ÿ› ๏ธ Bug fix (non-breaking change which fixes an issue)
  • [ ] โŒ Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] ๐Ÿงน Code refactor
  • [ ] โœ… Build configuration change
  • [ ] ๐Ÿ“ Documentation
  • [ ] ๐Ÿ—‘๏ธ Chore

Files Changed

  • packages/shorebird_cli/bin/shorebird.dart
  • packages/shorebird_cli/lib/src/commands/release/macos_releaser.dart
  • packages/shorebird_cli/lib/src/commands/release/release_command.dart
  • packages/shorebird_cli/lib/src/executables/executables.dart
  • packages/shorebird_cli/lib/src/executables/productbuild.dart (new)
  • packages/shorebird_cli/test/src/executables/productbuild_test.dart (new)

Summary

  • Implements signed PKG installer creation for macOS releases.
  • Adds CLI option for specifying PKG signing identity.
  • Adds productbuild wrapper and related tests.

Please review and let me know if further changes are needed.

ahmtydn avatar Jul 18 '25 19:07 ahmtydn

This looks really exciting.

kingdomseed avatar Aug 19 '25 21:08 kingdomseed