shorebird icon indicating copy to clipboard operation
shorebird copied to clipboard
verified publisher icon shorebirdtech

fix: iOS flutter_stripe assets always change

Open johnstef99 opened this issue 8 months ago • 3 comments

App ID: 844806f4-2b4c-4bf9-8ed0-7b8315fed0b2

Description

After adding flutter_stripe to my app the iOS patch always detects asset changes. The android patch is working just fine.

Steps To Reproduce

  1. Add flutter_stripe to your app and use it in you code
  2. Make a release
  3. Make a patchable change to your app
  4. Try patch the ios release

Expected Behavior

Seeing that the android version is patchable, I think the iOS should be too.

Additional Context

[WARN] Your app contains asset changes, which will not be included in the patch.
    Changed files:
        Products/Applications/Runner.app/Assets.car
        Products/Applications/Runner.app/Frameworks/Stripe.framework/StripeBundle.bundle/Assets.car
        Products/Applications/Runner.app/Frameworks/StripePaymentSheet.framework/StripePaymentSheetBundle.bundle/Assets.car
        Products/Applications/Runner.app/Frameworks/StripePayments.framework/Stripe3DS2.bundle/Assets.car
        Products/Applications/Runner.app/Frameworks/StripePaymentsUI.framework/StripePaymentsUIBundle.bundle/Assets.car
        Products/Applications/Runner.app/Frameworks/StripeUICore.framework/StripeUICoreBundle.bundle/Assets.car

johnstef99 avatar Apr 14 '25 11:04 johnstef99

Thanks for the report!

I suspect flutter_stripe might be generating a new uuid or something every time it builds? I'm not sure how it would do that though. I suspect we'll have to try and build a simple repro to learn more.

eseidel avatar Apr 14 '25 19:04 eseidel

@eseidel is it safe to release a patch though? I tried it testflight and the app worked fine but I am not 100% confident to release a patch in production. Could that diff in assets make the app crash?

johnstef99 avatar Apr 28 '25 09:04 johnstef99

I don't know why Assets.car is changing here. I suspect a patch would be safe, yes. We really would need to try ourselves to learn more.

eseidel avatar May 02 '25 19:05 eseidel

There appear to be ways to diff .car files (https://github.com/dotnet/macios/issues/12410#issuecomment-896862987), but I'm not able to reproduce this by following the repro steps in the initial bug.

Like Eric, I also suspect that the patch is safe, but it would be good to get a reliable reproduction so we could maybe improve how we communicate .car file differences.

bryanoltman avatar Jun 04 '25 20:06 bryanoltman

Sentry has a similar problem: https://github.com/shorebirdtech/shorebird/issues/3079.

Regardless, thank you for the report. It looks like there isn't anything for us to change?

eseidel avatar Nov 20 '25 19:11 eseidel