shorebird icon indicating copy to clipboard operation
shorebird copied to clipboard

fix: `shorebird patch ios` tells users to upload to app store

Open eseidel opened this issue 9 months ago • 1 comments

Building App Store IPA...                                          77.2s
✓ Built IPA to build/ios/ipa (33.6MB)
To upload to the App Store either:
    1. Drag and drop the "build/ios/ipa/*.ipa" bundle into the Apple Transporter macOS app https://apps.apple.com/us/app/transporter/id1450874784
    2. Run "xcrun altool --upload-app --type ios -f build/ios/ipa/*.ipa --apiKey your_api_key --apiIssuer your_issuer_id".
       See "man altool" for details about how to authenticate with the App Store Connect API key.
✓ Verifying patch can be applied to release (1.1s)
[WARN] Your ios/Podfile.lock is different from the one used to build the release.
This may indicate that the patch contains native changes, which cannot be applied with a patch. Proceeding may result in unexpected behavior or crashes.
Continue anyways? (y/N) y

I believe this is "regression" from how we changed how we print flutter output. We used to capture it all, but now we let it through. But this specific output is confusing to users.

eseidel avatar Apr 01 '25 19:04 eseidel

Technically we might be able to move away from using flutter build ipa under the covers? Which might hide this message? Or we could edit flutter to take a flag to not print it.

eseidel avatar Apr 01 '25 19:04 eseidel