shorebird icon indicating copy to clipboard operation
shorebird copied to clipboard

feat: Allow retry when making patches or releases

Open Aqudi opened this issue 2 years ago • 3 comments

Greetings to the Shorebird Development Team,

Firstly, I want to extend my heartfelt thanks for developing such a useful and efficient tool!

Description

When creating patches or releases using the shorebird_cli, the process requires confirmation to proceed (Would you like to continue? (y/N)). Currently, if any character other than 'y' or 'N' is entered, the process aborts immediately. This results in a significant take time to rebuild. I propose adding a feature to allow retrying the confirmation step without having to restart the entire build process.

Requirements

  • [ ] Ensure that if a character other than 'y' or 'N' is entered, the user is prompted again for confirmation.

Additional Context

Additional Context Below is an example of the current process where an accidental input leads to an abort, requiring a complete rebuild:

shorebird patch android
...
Would you like to continue? (y/N) No                                                                                                              
Aborting.

This feature would enhance the developer experience by reducing unnecessary delays and frustration.

Aqudi avatar Dec 14 '23 07:12 Aqudi

This is a good idea. I filed https://github.com/felangel/mason/issues/1202 with the CLI library we use, which is where the first bit of work for this would take place.

bryanoltman avatar Jan 02 '24 16:01 bryanoltman

This is a good idea. I filed https://github.com/felangel/mason/issues/1202 with the CLI library we use, which is where the first bit of work for this would take place.

Thank you!

Aqudi avatar Jan 07 '24 05:01 Aqudi