shopware
shopware copied to clipboard
implement fix for wrong sAddresses data issue. consider userId to get…
… unique order if there are multiple orders with same orderid
1. Why is this change necessary?
If multiple shops has not correctly setup the order nuber ranges and they overlap customer see billing data from other customer on /checkout/finish page.
2. What does this change do, exactly?
the change consider the userId and orderId to get the unique oder for the customer which does the checkout
3. Describe each step to reproduce the issue or behaviour.
If you have two stores with same odernumber ranges and for example Store A hast already the order 45500 and the second store now also has a new order with 45500, because of same order number ranges, the user from Store B will see the address data of user from Store A because the Method: getOrderAddress from Controller Shopware_Controllers_Frontend_Checkout just search for oder ID and does not consider Store oder User!
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist
- [ ] I have written tests and verified that they fail without my change
- [ ] I have squashed any insignificant commits
- [ ] This change has comments for package types, values, functions, and non-obvious lines of code
- [ ] I have read the contribution requirements and fulfil them.