shopware icon indicating copy to clipboard operation
shopware copied to clipboard

Changing language-string for privacyNotice

Open jonas-sfx opened this issue 2 years ago • 5 comments

1. Why is this change necessary?

Agreeing to the TOS/T&Cs is not mandatory for newsletter-recipients/contact-form users. By law this requirement is even to much.

2. What does this change do, exactly?

I just removed thid part out of a language-string.

3. Describe each step to reproduce the issue or behaviour.

You can see this Textblock in Contactforms or Newsletter-Registration-Forms next to a Checkbox that users have to activate.

4. Please link to the relevant issues (if any).

NEXT-23192

5. Checklist

  • [✅ ] I have rebased my changes to remove merge conflicts
  • [ ✗] I have written tests and verified that they fail without my change
  • [ ✅] I have created a changelog file with all necessary information about my changes
  • [✗ ] I have written or adjusted the documentation according to my changes
  • [ ✗] This change has comments for package types, values, functions, and non-obvious lines of code
  • [ ✅] I have read the contribution requirements and fulfil them.

jonas-sfx avatar Sep 14 '22 09:09 jonas-sfx

Thank you for your reply i will do that split.

Fun fact: About a year ago this String looked kind of like I would like to have it now.

The meshedup state with the TOS-Agreement came with commit 2c354dc107a89cf05638a741719ef2f90284fe87 And the intended Feature was "NEXT-16236 | Option: setting guest account as default "

jonas-sfx avatar Sep 14 '22 12:09 jonas-sfx

separate usage of contact.privacyNotice and newsletter.privacyNotice is imho not necessary. in the block cms_form_privacy_opt_in_label you should use the new variant (only privacy policy) and in all other cases we leave the old one (privacy-policy and TOSs)

jonas-sfx avatar Sep 14 '22 12:09 jonas-sfx

Where else is that component used where we want to use the only the privacy notice and not TOS?

The privacy-notice-string is currently used in the Cart-Process, Contact-Forms and if you add a new recipient to the newsletter-list. By law only in case of the shopping-cart-Process agreeing to the TOS is necessary in all other cases it should only be neccesary to know/agree to the privacy note.

jonas-sfx avatar Sep 15 '22 11:09 jonas-sfx

Hello,

thank you for creating this pull request. I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-23300

Please use this issue to track the state of your pull request.

shopwareBot avatar Sep 20 '22 08:09 shopwareBot

Hello,

thank you for creating this pull request. I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-23301

Please use this issue to track the state of your pull request.

shopwareBot avatar Sep 20 '22 08:09 shopwareBot

I talked to our legal department regarding the contact form and the newsletter and they stated that we need the user to accept

  • both the General terms and conditions and the Data protection information for the newsletter
  • just the Data protection information for the contact form

adrianles avatar Sep 23 '22 11:09 adrianles

Thank you for asking your legal department, @adrianles. But the GDPR (aka DSG-VO) is a law. And thus a checkbox that you comply with applicable laws seems quite weird to me! What you agree to is imho the data protection information or privacy policy.

wolf128058 avatar Sep 23 '22 12:09 wolf128058

Hello, The changes related to this issue are now merged. Thank you for your contribution.

adrianles avatar Oct 07 '22 05:10 adrianles